|
Message
From: k1e3c1@h...<k1e3c1@h...>
Date: Thu Jun 24 22:39:57 CEST 2004
Subject: [usb] Packet Disassembler for Rudi
Hello Rudi,I was going through the code to get a better understanding and to add low-speed option. I got to the Packet Disassembler and I have a few questions.
1.) All the #1 - I assume are for simulation knowing that the synthesis tool will remove these. 2.) In the state machine you have no else statements for your ifs. Are you assuming that the synthesis tool will optimize and will assume the else is the current state? 3.) You did not define all variable in all states. For example once pid_ack gets set in the ACTIVE state do you again assume the synthesis tool will optimize and clear the signal in the IDLE condition?
My guess is that this is coding style. I got burned by an old tool once and now I assign all variables in all states to be safe. My personal belt and suspenders approach.
erich
|