|
Message
From: Matjaz Breskvar<phoenix@o...>
Date: Wed Mar 30 19:17:50 CEST 2005
Subject: [openrisc] or1ksim patches #34, #43, #53-2, #64, #68-#73
Nog,This are the rest of my comments. #34 accepted.
#43 accepted.
#53-2 accepted.
#68 accepted.
#69 accepted.
#70 accepted.
#71 accepted.
#72 accepted.
#72 accepted with warning, how difficult would it be to add the 'not
working'
functionality when using recompiler. For now, please add a printf which will
complain if somebody uses recompiler and tries to patch a register or do
something else that is not supported in recompiler mode. (this will reduce
the number of support questions)
#73 accepted.
and now the big one... #64
i just got idea about the exec-schield,... just adding
__attribute__ ((__section__ (".text")))
to the static definition of variable should fix it. i don't know how
convinient is to do this, but it would remove the need for disabling
security (i'm guessing all distributions will migrate to
exec-protection, especialy with x86-64 extensions...)
well, i went over this patch very quickly, looking at it mostly from
maintaniability point of view. right now i'm very happy with it, but i'm
sure some issues will arise later. i'd also appriciate if more people tried
it and gave some feedback. so let's put this beast into cvs and see what
happens ;)...
all in all your patches look very good. i think we're moving torwards
cleaner simulator with some substantial improvments...
one more thing, there is a typo in user visible output, so this should
really be corrected:
diff -urp --unidirectional-new-file /home/nog/or1ksim-split/configure.in
./configure.in
--- /home/nog/or1ksim-split/configure.in 2005-03-24
18:29:09.000000000 +0100
+++ ./configure.in 2005-03-21 18:40:30.000000000 +0100
@@ -111,7 +111,7 @@ execution="1"
INCLUDES="-I\${top_builddir}/cpu/$CPU_ARCH"
AC_MSG_CHECKING(which execution style to use)
AC_ARG_ENABLE(execution,
- [ --enable-execution Executeion style to use (simple/complex)],
+ [ --enable-execution Execution style to use (simple/complex/dynamic)],
best regards,
p.
|
 |
Browse
