OPENCORES.ORG

* György 'nog' Jeney (nog@s...) wrote: > > > why not just copy the required definitions from inttypes.h (or maybe > > > even the whole file) and convince configure to use those if it can't > > > find the native one installed on system. there isn't much behind these > > > macros... > > > > > > /* UPPERCASE hexadecimal notation. */ > > > # define PRIX8 "X" > > > # define PRIX16 "X" > > > # define PRIX32 "X" > > > # define PRIX64 __PRI64_PREFIX "X" > > > > That's what I meant with `fix configure'. I think I'll use the official > > definitions they are availible and fall back to our (not yet existing) ones. > > I'll send an updated patch. > > Here's the updated patch. I have removed the extras subdirectory. It is really > a badly chosen name. There are no `extras' in there only `ports' of functions > that are not availible everywere, so I have renamed it to `port', the name given > in some other projects. I have also moved the isblank `port' from > cpu/common/parse.c to port/isblank.c, where it belongs. > > I have also added the printf attribute to the debug function, so gcc also checks > the format strings passed to that function. > > ChangeLog: > * Mark a simulated cpu address as such, by introducing the new oraddr_t type. I'm generaly ok with the patch though it needs some corrections. This is not entirely ok (yes it will work for now, but if we do stricter typing why not do it right ;) INSTRUCTION (l_sll) { - unsigned long temp1; + uint32_t temp1; The register size for this instruction is 64-bit on 64-bit architecture. So this shoult be of orreg_t ... (the same applies to other insns) Oh and the genexec.c file should be removed from cvs (or at least reneamed) because it breaks the out-of-tree builds. Besides that, the whole toolchain build & works ... best regards, p.