|
Message
From: Matjaz Breskvar<phoenix@o...>
Date: Tue Jan 25 15:04:11 CET 2005
Subject: [openrisc] [or1ksim #3] Warning fixes for insnset.c and execute.c
* György 'nog' Jeney (nog@s...) wrote:
> Hi,
>
> Now that --enable-simple works and we don't get hughe amounts of warnings from
> execgen.c, I have fixed most warnings in insnset.c and execute.c.
>
> ChangeLog:
> * Fix warnings in insnset.c and execute.c
I've been looking over the patches you sent. Everything looks
nice (provided it doesn't break other stuff, but we'll see that later),
just the big generate.c patch in previous email is not obvious to me.
Is it right to assume that the net effect of all the patches is:
- rD is always destination operand. the code now relies upon
this. ie. there can always be at most one destination register, when
before this wasn't neccessery (i know it's not needed for now). the gain
is faster simulator execution. (would you happen to have any esstimate?)
- cleanups/warnings elimination
If this is so i say let's commit the changes and cross our finger
it doesn't break anything. ;)
best regards,
p.
|
 |
Browse
