|
Message
From: Matjaz Breskvar<phoenix@o...>
Date: Thu Dec 30 17:06:52 CET 2004
Subject: [openrisc] Bug in hello-uart
* Patrick Loschmidt (Patrick.Loschmidt@o...) wrote:
> Hi!
>
> I'm not sure, whether this is the right mailing list, but there is a
> tricky bug in the hello-uart example program of or1k:
This is the right mailing list.
> Index: hello-uart/reset.S
> ===================================================================
> RCS file: /cvsroot/anonymous/or1k/hello-uart/reset.S,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 reset.S
> --- hello-uart/reset.S 7 Jan 2004 10:51:11 -0000 1.1.1.1
> +++ hello-uart/reset.S 30 Dec 2004 14:53:54 -0000
> @@ -11,7 +11,7 @@
> _reset:
> l.movhi r1,hi(_stack-4)
> l.ori r1,r1,lo(_stack-4)
> - l.addi r2,r0,-3
> + l.addi r2,r0,-4
> l.and r1,r1,r2
>
> l.movhi r2,hi(_main)
>
> I suppose that the -3 should do an alignment to 32bit words but this is
> not the case. Because -3 is b1101 or 0xD so it should be -4 equal to
> b1100 or 0xC. Could somebody please confirm this?
it's readibility bug in any case. Since this is an example, let's do
it really clearly:
l.movhi r2,hi(0xfffffffc)
l.ori r2,lo(0xfffffffc)
and now there is no confusion anymore.
regards,
p.
|
 |
Browse
